support MERGE SET #305
Merged
support MERGE SET #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/execution_plan/ops/op_merge.c
Outdated
|
|
||
| if(op->matched || op->created) return NULL; |
There was a problem hiding this comment.
I think that the matched part of this logic is not quite right, since it will cause only one entity to be updated:
$ redis-cli GRAPH.QUERY social "MATCH (a) WHERE a.age = 31 RETURN COUNT(a)"
1) 1) 1) "COUNT(a)"
2) 1) "4.000000"
2) 1) "Query internal execution time: 0.277327 milliseconds"
$ redis-cli GRAPH.QUERY social "MERGE (a {age: 31}) SET a.newprop = 100"
1) (empty list or set)
2) 1) "Properties set: 1"
2) "Query internal execution time: 0.107706 milliseconds"
There was a problem hiding this comment.
Need to check if that's the expected behavior
There was a problem hiding this comment.
Indeed that's the case 👍
jeffreylovitz
suggested changes
Jan 2, 2019
There was a problem hiding this comment.
One comment not on updated files:
op_update.c:100
op_update.c:
100:
change from = to += so that the properties_set count created by MERGE doesn't get overwritten.
$ redis-cli GRAPH.QUERY social "MERGE (a:newlabel {name: 'ewweccwd'}) SET a.secondprop = 4"
1) (empty list or set)
2) 1) "Labels added: 1"
2) "Nodes created: 1"
3) "Properties set: 1"
4) "Query internal execution time: 0.611405 milliseconds"
jeffreylovitz
approved these changes
Jan 3, 2019
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* support MERGE SET * merge pass down multiple matches * merge clause name anonymou nodes * adding to resultset stats instead of overwriting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.