added IS NULL and IS NOT NULL unary operators #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swilly22
suggested changes
Sep 10, 2019
| char *values[6] = {"1", "1.2", "true", "false", "'string'", "[1,2,3]"}; | ||
| for (int i = 0; i < 6; i++) | ||
| { | ||
| char buff[100]; |
There was a problem hiding this comment.
buff[1024] just to be aligned.
| @@ -182,8 +182,8 @@ static void _buildOperatorsWhitelist(void) { | |||
| CYPHER_OP_STARTS_WITH, | |||
| CYPHER_OP_ENDS_WITH, | |||
| CYPHER_OP_CONTAINS, | |||
| // CYPHER_OP_IS_NULL, | |||
| // CYPHER_OP_IS_NOT_NULL, | |||
| CYPHER_OP_IS_NULL, | |||
| @@ -788,36 +788,10 @@ static AST_Validation _Validate_DELETE_Clauses(const AST *ast, char **reason) { | |||
| return AST_VALID; | |||
| } | |||
|
|
|||
| // Verify that we handle the projected types. An example of an unsupported projection is: | |||
| // RETURN count(a) > 0 | |||
| static AST_Validation _Validate_ReturnedTypes(const cypher_astnode_t *return_clause, | |||
src/ast/ast_build_filter_tree.c
Outdated
| @@ -121,7 +126,8 @@ static FT_FilterNode *_convertFalseOperator() { | |||
| return FilterTree_CreateExpressionFilter(exp); | |||
| } | |||
|
|
|||
| static FT_FilterNode *_convertIntegerOperator(RecordMap *record_map, const cypher_astnode_t *expr) { | |||
| static FT_FilterNode *_convertIntegerOperator(RecordMap *record_map, | |||
There was a problem hiding this comment.
This should be a single line.
| case OP_IS_NOT_NULL: | ||
| return FilterTree_CreateExpressionFilter(AR_EXP_FromExpression(record_map, op_node)); | ||
| default: | ||
| return _CreateFilterSubtree(record_map, op, arg, NULL); |
There was a problem hiding this comment.
Can you give an example of Unary operator?
There was a problem hiding this comment.
NOT
This line was the function original execution code before the switch scope
src/ast/ast_build_ar_exp.c
Outdated
| @@ -164,6 +168,14 @@ static AR_ExpNode *_AR_EXP_FromUnaryOpExpression(RecordMap *record_map, | |||
| AR_ExpNode *op = AR_EXP_NewOpNodeFromAST(OP_NOT, 1); | |||
| op->op.children[0] = _AR_EXP_FromExpression(record_map, arg); | |||
| return op; | |||
| } else if(operator == CYPHER_OP_IS_NULL) { | |||
| AR_ExpNode *op = AR_EXP_NewOpNodeFromAST(OP_IS_NULL, 1); | |||
There was a problem hiding this comment.
Place AR_ExpNode *op at the beginning of the function, such that it is declared once,
AR_ExpNode *op = NULL
have a single else where we assert false.
at the very end simply return op.
DvirDukhan
force-pushed
the
is_unary_operator
branch
from
397397f
to
217582d
Compare
DvirDukhan
force-pushed
the
is_unary_operator
branch
from
217582d
to
4bd833e
Compare
swilly22
approved these changes
Sep 10, 2019
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* added IS NULL and IS NOT NULL * changed according to PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added both IS NULL and IS NOT NULL unary operators to the arsenal. They can be used both as an expression the evaluate in RETURN clause, or as a leaf in a filter tree.
Added a test in test_arithmetic_expression.cpp
Enabled some TCK scenarios
Added a flow test for filter testing, since currently no TCK tests are enabled with those tests