add redis-cli parameter example #1333

odanoburu · 2020-09-10T17:38:12Z

I could not find how to set parameters on redis-cli on the documentation, so I added it here. Is there a better place? maybe https://oss.redislabs.com/redisgraph/commands/?

I could not find how to set parameters on `redis-cli` on the documentation, so I added it here. Is there a better place? maybe https://oss.redislabs.com/redisgraph/commands/?

CLAassistant · 2020-09-10T17:38:17Z

All committers have signed the CLA.

jeffreylovitz

Thanks for adding this!

I agree that this is a somewhat awkward location for the example, but would prefer to not overload the already lengthy Commands page more than it already is.

I think that the sections pertaining to Cypher syntax and function/procedure invocations should ultimately be migrated to their own page, at which time it will be easier to place this more appropriately. For the moment, I think the location you chose is fine!

My one request on this is that we use two parameters, such as:

CYPHER name_param = "Niccolò Machiavelli" birth_year_param = 1469; MATCH (p:Person {name: $name_param, birth_year: $birth_year_param}) RETURN p

to make it clear how to use more than a single parameter

odanoburu · 2020-09-23T01:51:38Z

done! that's a good suggestion, since at some point I wondered how parameters were separated from each other (although trial and error was enough to show it, it's good to be as complete as possible!)

jeffreylovitz

👍 Thank you for the contribution!

* add redis-cli parameter example I could not find how to set parameters on `redis-cli` on the documentation, so I added it here. Is there a better place? maybe https://oss.redislabs.com/redisgraph/commands/? * * add a second parameter to make it clear how to use more than a single parameter Co-authored-by: Guy Korland <gkorland@gmail.com> (cherry picked from commit 3f19bd1)

* Fuzzy test crashes 2 (#1429) * Validate number of RETURNs in UNION query * Improve error handling and messages with invalid WHERE clauses * Revert changes to optimize_cartesian_product * Add run-time error for non-boolean predicate constants in runtime values (cherry picked from commit ebfc507) * improve graph loading time by noting multi-edge matrices (#1426) * improve graph loading time by noting multi-edge matices * compute multi-edge only once (cherry picked from commit 514fa25) * Explicitly assign allocation type of SIValue primitives (#1435) (cherry picked from commit 5d6fdfc) * Disallow property assignment to complex data types (#1432) * Disallow property assignment to complex data types * Address PR comments * Capture errors before committing updates Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 524f171) * Don't assert on failed MERGE updates (#1437) * Don't assert on failed MERGE updates * Update op_merge.c Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit b2dadd8) * Disallow traversal patterns outside of the appropriate clauses (#1431) * Disallow traversal patterns outside of the appropriate clauses * Address PR comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 0f53447) * add redis-cli parameter example (#1333) * add redis-cli parameter example I could not find how to set parameters on `redis-cli` on the documentation, so I added it here. Is there a better place? maybe https://oss.redislabs.com/redisgraph/commands/? * * add a second parameter to make it clear how to use more than a single parameter Co-authored-by: Guy Korland <gkorland@gmail.com> (cherry picked from commit 3f19bd1) * Fix warnings reported by fb-infer (#1440) * Fix warnings reported by fb-infer * validate algebraic expression structure on evaluation Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: swilly22 <roi@redislabs.com> (cherry picked from commit eefb8ef) * Delete redundant check to create edge schemas (#1444) (cherry picked from commit 17663a6) * Fixed bug in OSX build instructions (#1448) CPP is the environment variable for the preprocessor executable, CXX specifies the compiler path. (cherry picked from commit 88048ee) * Disallow MERGE of entities with null properties (#1442) * Disallow MERGE of entities with null properties * Fix memory leak * Move error-handling functions to errors.c * Fix NULL serialization logic * Address PR comments * Address PR comments * Move all error-handling logic to errors.c * Fix memory leak * Fix unit test * Initialize ErrorCtx thread-local key * reuse TLS error context, set and raise error in one call * remove unused include * Reset error breakpoint after every query * Don't delete property update maps on encountering NULL values * Add Valgrind suppression * Expose ErrorCtx getter for identical logic in handler macro Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: swilly22 <roi@redislabs.com> (cherry picked from commit c972f72) * new php client redislabs-redisgraph-php added (#1461) * new php client redislabs-redisgraph-php added * columns are aligned. * Update clients.md * Update clients.md Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit bbd5993) * Add new rust client with async support (#1456) Co-authored-by: Guy Korland <gkorland@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 081c863) * validate clauses following a RETURN clause (#1460) * validate clauses following a RETURN clause * relocated return clause sequance validation * Update ast_validations.c (cherry picked from commit 2157919) * Add C# clients (#1469) (cherry picked from commit 682a5ba) * switch from assert to debug assert (#1463) * switch from assert to debug assert * Continue converting to debug assert * Revert changes to RG.h * switch from system assert to RedisModule_Assert * re-order include sequence Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> (cherry picked from commit 8345677) * Add stars to clients (#1462) * Add stars to clients * Update clients.md (cherry picked from commit b3e4222) * Add stars to clients (#1462) (#1464) * Add stars to clients * Update clients.md (cherry picked from commit b3e4222) * Optimize cartesian product scoping (#1446) * Don't recurse into previous scopes when optimizing Cartesian Products * Fix crash on migrating cartesian products with constant filters * Don't assert on non-filter branch head * Avoid memory leak * Fix memory leak (cherry picked from commit 9b82f8b) * bump version to 2.2.9 Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: bc² <odanoburu@users.noreply.github.com> Co-authored-by: Christoph Zimmermann <40485189+chrisAtRedis@users.noreply.github.com> Co-authored-by: Mehmet Korkmaz <mehmet@mkorkmaz.com> Co-authored-by: Thomas Profelt <office@protom.eu> Co-authored-by: Guy Korland <gkorland@gmail.com>

* add redis-cli parameter example I could not find how to set parameters on `redis-cli` on the documentation, so I added it here. Is there a better place? maybe https://oss.redislabs.com/redisgraph/commands/? * * add a second parameter to make it clear how to use more than a single parameter Co-authored-by: Guy Korland <gkorland@gmail.com>

add redis-cli parameter example

35f493e

I could not find how to set parameters on `redis-cli` on the documentation, so I added it here. Is there a better place? maybe https://oss.redislabs.com/redisgraph/commands/?

jeffreylovitz suggested changes Sep 22, 2020

View reviewed changes

jeffreylovitz added the Documentation label Sep 22, 2020

odanoburu and others added 2 commits September 22, 2020 22:48

* add a second parameter

e76d1d6

to make it clear how to use more than a single parameter

Merge branch 'master' into patch-1

283cfc5

Merge branch 'master' into patch-1

591a180

gkorland requested a review from jeffreylovitz November 18, 2020 10:31

jeffreylovitz approved these changes Nov 18, 2020

View reviewed changes

jeffreylovitz requested a review from swilly22 November 18, 2020 14:11

swilly22 approved these changes Nov 19, 2020

View reviewed changes

swilly22 merged commit 3f19bd1 into RedisGraph:master Nov 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add redis-cli parameter example #1333

add redis-cli parameter example #1333

odanoburu commented Sep 10, 2020

CLAassistant commented Sep 10, 2020 •

edited

jeffreylovitz left a comment

odanoburu commented Sep 23, 2020

jeffreylovitz left a comment

add redis-cli parameter example #1333

add redis-cli parameter example #1333

Conversation

odanoburu commented Sep 10, 2020

CLAassistant commented Sep 10, 2020 • edited

jeffreylovitz left a comment

Choose a reason for hiding this comment

odanoburu commented Sep 23, 2020

jeffreylovitz left a comment

Choose a reason for hiding this comment

CLAassistant commented Sep 10, 2020 •

edited