Fix transfer of SIValue ownership in DISTINCT function #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2176 +/- ##
==========================================
- Coverage 93.08% 93.08% -0.01%
==========================================
Files 251 251
Lines 22523 22523
==========================================
- Hits 20966 20965 -1
- Misses 1557 1558 +1
Continue to review full report at Codecov.
|
swilly22
approved these changes
Feb 27, 2022
AviAvni
pushed a commit
that referenced
this pull request
Mar 2, 2022
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
swilly22
added a commit
that referenced
this pull request
Mar 7, 2022
* Add rueidis to the client list of README.md (#2153) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Document how to set run-time configurations (#2161) * Add rueidis to the client list of README.md (#2153) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * check for queries with different than 1 statement (#2163) * check for invalid queries * address review * spelling * Update test_query_validation.py Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * fix benchmarks name (#2174) * Bind Argument ops to the subplan they belong to (#2167) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Fix transfer of SIValue ownership in DISTINCT function (#2176) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Modern GCC for ARM (#2181) * Modern GCC for ARM * fixes 1 * Add "dsl" field for query arguments of commands (#2180) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * fix perf issue of allShortestPath (#2173) * fix perf issue * review comments * renaming * removed TODO Co-authored-by: swilly22 <roi@redislabs.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * add arm to deploy branch (#2182) * Remove purposeless variable check in comprehensions (#2155) * Remove purposeless variable check in comprehensions * Fix test * add test * comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Avi Avni <avi.avni@gmail.com> * aggregation should return a default values when aggregation is keyles… (#2151) * aggregation should return a default values when aggregation is keyless and no data was processed * update graph deletion tests * address PR comments * use child record to perform forced aggregation * update construction logic * WIP * fix build * fixs for test * wip * fix * fix * fix * fix tck * reviews * WIP * WIP * WIP * WIP * refactor * address review comments * fix leak Co-authored-by: Avi Avni <avi.avni@gmail.com> Co-authored-by: Rueian <rueiancsie@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Rafi Einstein <raffapen@outlook.com> Co-authored-by: romansergeenkosofteq <roman.sergeenko@softeq.com> Co-authored-by: swilly22 <roi@redislabs.com>
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an invalid assumption about SIValue memory scope in the
Distinctfunction.Resolves #2171