Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push clause to call_subquery #3121

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 3 additions & 35 deletions src/ast/ast_rewrite_call_subquery.c
Original file line number Diff line number Diff line change
Expand Up @@ -232,25 +232,7 @@
// -------------------------------------------------------------------------
// replace original clause with fully populated one
// -------------------------------------------------------------------------

cypher_astnode_t *query = cypher_ast_call_subquery_get_query(callsubquery);

uint n_clauses = cypher_ast_query_nclauses(query);
cypher_astnode_t *clauses[n_clauses + 1];
for(uint i = 0; i < first_ind; i++) {
clauses[i] = cypher_ast_clone(cypher_ast_query_get_clause(query, i));
}

clauses[first_ind] = new_clause;

for(uint i = first_ind; i < n_clauses; i++) {
clauses[i + 1] = cypher_ast_clone(cypher_ast_query_get_clause(query, i));
}

cypher_astnode_t *q = cypher_ast_query(NULL, 0, clauses, n_clauses + 1,
clauses, n_clauses + 1, range);

cypher_ast_call_subquery_replace_query(callsubquery, q);
cypher_ast_call_subquery_push_clause(callsubquery, new_clause, first_ind);
}

// replace all intermediate WITH clauses in the query with new WITH clauses,
Expand Down Expand Up @@ -563,29 +545,15 @@
query = cypher_ast_call_subquery_get_query(node);
}

uint nclauses = cypher_ast_query_nclauses(query);

// create a star projection
struct cypher_input_range range = {0};
cypher_astnode_t *star_projection = cypher_ast_with(false, true, NULL, 0,
NULL, NULL, NULL, NULL, NULL, 0, range);

cypher_astnode_t *clauses[nclauses + 1];
for(uint i = 0; i < idx; i++) {
clauses[i] = cypher_ast_clone(cypher_ast_query_get_clause(query, i));
}
clauses[idx] = star_projection;
for(uint i = idx; i < nclauses; i++) {
clauses[i + 1] = cypher_ast_clone(cypher_ast_query_get_clause(query, i));
}

cypher_astnode_t *new_query = cypher_ast_query(NULL, 0, clauses,
nclauses + 1, clauses, nclauses + 1, range);

if(type == CYPHER_AST_STATEMENT) {
cypher_ast_statement_replace_body(node, new_query);
cypher_ast_statement_push_clause(node, star_projection, idx);
} else {
cypher_ast_call_subquery_replace_query(node, new_query);
cypher_ast_call_subquery_push_clause(node, star_projection, idx);
}
}

Expand Down Expand Up @@ -641,7 +609,7 @@
const cypher_astnode_t *root // root of AST
) {
if(cypher_astnode_type(root) != CYPHER_AST_STATEMENT) {
return false;

Check warning on line 612 in src/ast/ast_rewrite_call_subquery.c

View check run for this annotation

Codecov / codecov/patch

src/ast/ast_rewrite_call_subquery.c#L612

Added line #L612 was not covered by tests
}

// retrieve the root's body
Expand Down
Loading