fix crash when consume depleted ops #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3194 +/- ##
=======================================
Coverage 90.89% 90.89%
=======================================
Files 294 294
Lines 30407 30407
=======================================
Hits 27639 27639
Misses 2768 2768
☔ View full report in Codecov by Sentry. |
swilly22
reviewed
Sep 26, 2023
| @@ -133,7 +133,7 @@ static Record _handoff | |||
| ( | |||
| OpCreate *op | |||
| ) { | |||
| return array_pop(op->records); | |||
| return (array_len(op->records)) ? array_pop(op->records) : NULL; | |||
There was a problem hiding this comment.
The idea was to place a NULL as a marker
so you pop the last element which is NULL and we're done
There was a problem hiding this comment.
the problem is that op_cond_traverse can call to this consume after it get the marker null and we can't do anything to change it
There was a problem hiding this comment.
I wonder why the operation continues on asking for more data after it received NULL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.