support multi-exec #352
Merged
support multi-exec #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/commands/cmd_query.c
Outdated
| GraphContext *gc = GraphContext_Retrieve(ctx, qctx->graphName); | ||
| RedisModule_ThreadSafeContextUnlock(ctx); | ||
|
|
||
| CommandCtx_ThreadSafeContextUnlock(qctx); |
There was a problem hiding this comment.
theadeSafeCtx should be released only after the 'if(!gc)' block to prevent edge case of two writers that create a new graph simultaneously and one of them failed
MeirShpilraien
previously approved these changes
Feb 10, 2019
| context->argc = argc; | ||
|
|
||
| // Make a copy of graph name. | ||
| if(graphName) context->graphName = rm_strdup(RedisModule_StringPtrLen(graphName, NULL)); |
There was a problem hiding this comment.
Set context->graphName to NULL if not provided.
src/commands/cmd_context.c
Outdated
| } | ||
|
|
||
| if(qctx->ast) AST_Free(qctx->ast); | ||
| rm_free(qctx->graphName); |
There was a problem hiding this comment.
Safer to have an if condition on this free.
src/commands/cmd_context.c
Outdated
| // Either we already have a context or block client is set. | ||
| if(qctx->ctx) return qctx->ctx; | ||
|
|
||
| assert(!qctx->ctx && qctx->bc); |
There was a problem hiding this comment.
Left-hand condition unnecessary.
src/commands/cmd_query.c
Outdated
|
|
||
| // Replicate only if query has potential to modify key space. | ||
| bool readonly = AST_ReadOnly(ast); |
There was a problem hiding this comment.
Invalid read if we attached an AST to the QueryContext, since ast is freed by now.
jeffreylovitz
suggested changes
Feb 10, 2019
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* support multi-exec * deal with multiple concurrent writers, when graph does not exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#333
MULTI
GRAPH.QUERY G QUERY
GRAPH.QUERY G QUERY
GRAPH.QUERY G QUERY
EXEC