Escape html entities in console

Fix #4020
RedisInsight · Mar 2, 2018 · 12662d1 · 12662d1
1 parent 6011ea7
commit 12662d1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/src/app/qmlutils.cpp b/src/app/qmlutils.cpp
@@ -165,3 +165,8 @@ void QmlUtils::deleteTextWrapper(QObject *w)
         w->deleteLater();
     }
 }
+
+QString QmlUtils::escapeHtmlEntities(const QString &t)
+{
+    return t.toHtmlEscaped();
+}
diff --git a/src/app/qmlutils.h b/src/app/qmlutils.h
@@ -22,4 +22,5 @@ class QmlUtils : public QObject
     Q_INVOKABLE void addNewValueToDynamicChart(QtCharts::QXYSeries* series, double value);
     Q_INVOKABLE QObject* wrapLargeText(const QByteArray &text);
     Q_INVOKABLE void deleteTextWrapper(QObject* w);
+    Q_INVOKABLE QString escapeHtmlEntities(const QString& t);
 };
diff --git a/src/qml/console/QConsole.qml b/src/qml/console/QConsole.qml
@@ -38,9 +38,9 @@ Rectangle {
     function addOutput(text, type) {
 
         if (type == "error") {
-            textArea.append("<span style='color: red'>" + text + '</span>')
+            textArea.append("<span style='color: red'>" + qmlUtils.escapeHtmlEntities(text) + '</span>')
         } else {
-            textArea.append("<pre style='color: white'>" + text + '</pre>')
+            textArea.append("<pre style='color: white'>" + qmlUtils.escapeHtmlEntities(text) + '</pre>')
         }
 
         if (type == "complete" || type == "error") {