Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution examples in JSON MSET doc #1162

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

enjoy-binbin
Copy link
Contributor

In fact, executing the example directly will return this error:

redis> flushall
OK
redis> JSON.MSET doc1 $ '{"a":2}' doc2 $.f.a '3' doc3 $ '{"f1": {"a":1}, "f2":{"a":2}}'
(error) ERR new objects must be created at the root

Add some JSON.SET in front of the example to avoid error and fix
the incorrect responses.

In fact, executing the example directly will return this error:
```
redis> flushall
OK
redis> JSON.MSET doc1 $ '{"a":2}' doc2 $.f.a '3' doc3 $ '{"f1": {"a":1}, "f2":{"a":2}}'
(error) ERR new objects must be created at the root
```

Add some JSON.SET in front of the example to avoid error and fix
the incorrect responses.
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a27a0a7) 78.04% compared to head (aa086e7) 78.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1162   +/-   ##
=======================================
  Coverage   78.04%   78.04%           
=======================================
  Files          15       15           
  Lines        3885     3885           
=======================================
  Hits         3032     3032           
  Misses        853      853           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiorKogan LiorKogan self-requested a review December 19, 2023 11:10
@LiorKogan LiorKogan self-requested a review December 19, 2023 11:13
docs/commands/json.mset.md Outdated Show resolved Hide resolved
@LiorKogan LiorKogan merged commit 619b3d9 into RedisJSON:master Dec 19, 2023
13 checks passed
@enjoy-binbin enjoy-binbin deleted the fix_json_mset_exmaple branch December 19, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants