Fixes for CI benchmarks: iteration 2 #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
filipecosta90
commented
May 7, 2021
•
filipecosta90
commented
- Including module artifact check on benchmarks.
- Included extra dev docs explaining benchmark triggering.
- Increases the JSON.ARRAPPEND test duration given the major regression ( fixed by Fix json.arrappend performance #324 ) is now merged.
- Fixes some wrong benchmark names
- Make usage of readies/bin/getterraform and remove the explicit code for fetching terraform from repo
filipecosta90
added
the
x:quality
|
@filipecosta90 I fixed the rust installation issue. However, I'm wary of the build cache (esp. how it's used here). I think we should stop using it. WDYT? |
rafie
reviewed
May 11, 2021
…ev docs explaining benchmark triggering.
filipecosta90
force-pushed
the
ci.benchmark.fixes
branch
from
fd672e5
to
acfb23d
Compare
…ration now that major regression is fixed
…able_jsonsl-yahoo2_json
rafie
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.