Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List ingress and egress separately on JSON and CSV exports. Include BW and also raw values per second #246

Merged
merged 5 commits into from
Dec 24, 2023

Conversation

filipecosta90
Copy link
Collaborator

The following PR:

  • List ingress and egress separately on JSON and CSV exports.
  • Include overall BW results in the JSON and CSV and also raw values per second in the JSON timeseries
  • This PR is backwards compatible on the JSON output

excerpt from the json output showcasing the added overall metrics ("KB/sec RX/TX", "KB/sec RX", "KB/sec TX") and the per second ones ("Bytes RX","Bytes TX")

,"Gets":{
			"Count": 2000000
			,"Ops/sec": 311352.91
			,"Hits/sec": 311352.91
			,"Misses/sec": 0.00
			,"Latency": 0.643
			,"Average Latency": 0.643
			,"Min Latency": 0.008
			,"Max Latency": 5.183
			,"KB/sec": 20922.58
			,"KB/sec RX/TX": 20922.58
			,"KB/sec RX": 11858.17
			,"KB/sec TX": 9064.41
			,"Time-Serie":{
				"0":{
					"Bytes RX": 12263160
					,"Bytes TX": 9372271
					,"Count": 314440
(...)
(...)

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (912a6da) 62.22% compared to head (c1d08b5) 64.53%.

Files Patch % Lines
run_stats.cpp 57.69% 22 Missing ⚠️
run_stats_types.cpp 87.87% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   62.22%   64.53%   +2.31%     
==========================================
  Files          21       21              
  Lines        4347     4368      +21     
==========================================
+ Hits         2705     2819     +114     
+ Misses       1642     1549      -93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filipecosta90 filipecosta90 merged commit 20c013d into master Dec 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants