add support for multiple arbitrary commands #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit expand the ability of running arbitrary command to enable runing multiple arbitrary commands by adding the --command option for each command.
YaacovHazan
force-pushed
the
multiple_arbitrary_command
branch
from
c56d3f0
to
0eaf608
Compare
yossigo
requested changes
Apr 16, 2019
memtier_benchmark.cpp
Outdated
|
|
||
| static bool verify_arbitrary_command_option(struct benchmark_config *cfg) { | ||
| if (cfg->key_pattern) { | ||
| fprintf(stderr, "error: when using arbitrary command, key pattern doesn't configured via key-pattern option.\n"); |
There was a problem hiding this comment.
typo: isn't.
also: maybe hint to the correct option to use?
memtier_benchmark.cpp
Outdated
| fprintf(stderr, "error: when using arbitrary command, key pattern doesn't configured via key-pattern option.\n"); | ||
| return false; | ||
| } else if (cfg->ratio.is_defined()) { | ||
| fprintf(stderr, "error: when using arbitrary command, ratio doesn't configured via ratio option.\n"); |
cr fixes + adding command line usage
yossigo
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit expand the ability of running arbitrary command
to enable runing multiple arbitrary commands by
adding the --command option for each command.