Fix empty payment when updating subscriptions #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
- payment_method_id as a computed attribute.
…ted on the original payment_method_id
…subscriptions_adjusted Reverts the introduction of contract_payment_method_id
trentrosenbaum
approved these changes
Oct 29, 2021
trentrosenbaum
approved these changes
Nov 1, 2021
trentrosenbaum
deleted the
fix_empty_payment_when_updating_subscriptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we've fixed the issue with updating an existing subscription for contract associated accounts by setting the
payment_method_idfield as computed. This PR addresses the following issue #146