Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refectoring of redismodule.h #42

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Refectoring of redismodule.h #42

wants to merge 13 commits into from

Conversation

rafie
Copy link
Contributor

@rafie rafie commented Aug 29, 2019 •
edited
Loading

  • Adapted scheme used in RediSearch (i.e., REDISMODULE_XAPI_* macros)
  • Have X in REDISMODULE_XAPI_*(X) receive (TYPE, NAME, ARGS) tripplet instead of (NAME),
    which makes it possible to avoid double-dipping of API names

@rafie
Refectoring of redismodule.h
124b6a7 
- Adapted scheme used in RediSearch (i.e., REDISMODULE_XAPI_* macros)
- Have X REDISMODULE_XAPI_*(X) receive (TYPE, NAME, ARGS) tripplet instead of (NAME),
  which makes it possible to avoid double-dipping of API names
@rafie rafie removed the request for review from mnunberg June 4, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeirShpilraien MeirShpilraien Awaiting requested review from MeirShpilraien

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rafie