Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix first empty sample on aggregation #323

Merged
merged 2 commits into from
Jan 26, 2020

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Jan 26, 2020

Fix empty first aggregation discovered by Java client

@ashtul ashtul added the bug Something isn't working label Jan 26, 2020
@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #323 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage    95.6%   95.61%   +<.01%     
==========================================
  Files          11       11              
  Lines        1684     1687       +3     
==========================================
+ Hits         1610     1613       +3     
  Misses         74       74
Impacted Files Coverage Δ
src/module.c 94.13% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f437163...4dcf7b7. Read the comment docs.

@gkorland gkorland merged commit 4928496 into master Jan 26, 2020
@gkorland gkorland deleted the fix-first-empty-sample-on-aggregation branch January 26, 2020 09:13
@filipecosta90 filipecosta90 mentioned this pull request Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants