Support mariner via github action [MOD-5872] #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1516 +/- ##
=======================================
Coverage 89.02% 89.02%
=======================================
Files 35 35
Lines 5834 5834
=======================================
Hits 5194 5194
Misses 640 640 ☔ View full report in Codecov by Sentry. |
alonre24
changed the title
GuyAv46
reviewed
Oct 9, 2023
.github/workflows/mariner2.yml
Outdated
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: 'recursive' | ||
| set-safe-directory: true |
There was a problem hiding this comment.
Can checkout get true here? I was under the impression it takes a path (or * for all).
There was a problem hiding this comment.
yes, when I tried with "'*'" (as I saw you did) I got an error...
There was a problem hiding this comment.
and without specifying set-safe-directory does it work?
There was a problem hiding this comment.
yes, because I have git config --global --add safe.directory $PWD in mariner2.sh
GuyAv46
reviewed
Oct 9, 2023
GuyAv46
approved these changes
Oct 10, 2023
alonre24
added a commit
that referenced
this pull request
Oct 10, 2023
Support mariner via github action [MOD-5872]
YaacovHazan
pushed a commit
that referenced
this pull request
Dec 7, 2023
Support mariner via github action [MOD-5872]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support mariner2 OS
Use github actions rather than circle-ci and a compact workflow.
Also, since setting the required configs in redis via RLTest to ensure that we can run debug commands and change protected configs in redis (previously this has been done via patch in
getredisscript)MOD-5872