Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOD-6015 link to openssl11 on Amazon Linux 2. #1538

Merged
merged 4 commits into from Nov 28, 2023

Conversation

MeirShpilraien
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023

CLA assistant check
All committers have signed the CLA.

chayim
chayim previously approved these changes Nov 21, 2023
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right...

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75cf173) 89.02% compared to head (326d129) 89.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1538   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files          35       35           
  Lines        5834     5834           
=======================================
  Hits         5194     5194           
  Misses        640      640           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MeirShpilraien
Copy link
Collaborator Author

Verified locally that the changes works and we link to openssl11 on Amazon Linux 2.

then
OS='macos'
else
VERSION=$(grep '^VERSION_ID=' /etc/os-release | sed 's/"//g')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I would source /etc/os-release then deal with it. It's key/value pairs and meant for shell scripts.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are gone drop this code anyway when we refactor the build system and this is how it is currently done on search so I wanted to keep it the same.
Is it critical?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical, no. But I'd rather do it now, while we're here. WDYT:

. /etc/os-release
VERSION=${VERSION_ID}

@MeirShpilraien MeirShpilraien merged commit ca23346 into master Nov 28, 2023
16 checks passed
@MeirShpilraien MeirShpilraien deleted the MOD-6015_link_to_openssl11_on_amzn2 branch November 28, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants