New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOD-6015 link to openssl11 on Amazon Linux 2. #1538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1538 +/- ##
=======================================
Coverage 89.02% 89.02%
=======================================
Files 35 35
Lines 5834 5834
=======================================
Hits 5194 5194
Misses 640 640 ☔ View full report in Codecov by Sentry. |
Verified locally that the changes works and we link to openssl11 on Amazon Linux 2. |
then | ||
OS='macos' | ||
else | ||
VERSION=$(grep '^VERSION_ID=' /etc/os-release | sed 's/"//g') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally I would source /etc/os-release then deal with it. It's key/value pairs and meant for shell scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are gone drop this code anyway when we refactor the build system and this is how it is currently done on search so I wanted to keep it the same.
Is it critical?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical, no. But I'd rather do it now, while we're here. WDYT:
. /etc/os-release
VERSION=${VERSION_ID}
No description provided.