Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #304 #306 #307

Closed
wants to merge 3 commits into from
Closed

Fix issue #304 #306 #307

wants to merge 3 commits into from

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Jan 19, 2020

No description provided.

@ashtul ashtul requested a review from danni-m as a code owner January 19, 2020 16:56
@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #307 into 1.2 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##             1.2    #307   +/-   ##
=====================================
  Coverage   93.3%   93.3%           
=====================================
  Files         11      11           
  Lines       1672    1672           
=====================================
  Hits        1560    1560           
  Misses       112     112
Impacted Files Coverage Δ
src/gorilla.c 99.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6abaa4b...64fa352. Read the comment docs.

@ashtul
Copy link
Contributor Author

ashtul commented Jan 20, 2020

#310 is the right fix

@ashtul ashtul closed this Jan 20, 2020
@ashtul ashtul deleted the fix-issue-#304-#306 branch February 5, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant