Add support for filter by queries #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
==========================================
+ Coverage 87.55% 87.91% +0.35%
==========================================
Files 22 23 +1
Lines 3769 3863 +94
==========================================
+ Hits 3300 3396 +96
+ Misses 469 467 -2
Continue to review full report at Codecov.
|
filipecosta90
requested changes
May 11, 2021
There was a problem hiding this comment.
@danni-m I believe the only things we're missing is:
FILTER_BY_VALUEsame look and fell of https://redis.io/commands/zrangebyscore. Like we said we would add.- small negative test on the missing covered LOC
- small addition to the docs explaining the
FILTER_BY_VALUEandFILTER_BY_TS
wdyt?
| return TSDB_ERROR; | ||
| } | ||
|
|
||
| if (RedisModule_StringToDouble(argv[offset + 1], &args->min) != REDISMODULE_OK) { |
There was a problem hiding this comment.
allow for -inf, and ( explicit interval just like https://redis.io/commands/zrangebyscore#exclusive-intervals-and-infinity
| return TSDB_ERROR; | ||
| } | ||
|
|
||
| if (RedisModule_StringToDouble(argv[offset + 2], &args->max) != REDISMODULE_OK) { |
There was a problem hiding this comment.
allow for +inf, and ) explicit interval just like https://redis.io/commands/zrangebyscore#exclusive-intervals-and-infinity
filipecosta90
previously approved these changes
May 20, 2021
filipecosta90
approved these changes
May 24, 2021
This was referenced May 25, 2021
This was referenced Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.