Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #655 - Add aggregation alignment option #801

Merged
merged 6 commits into from
Jul 27, 2021
Merged

Fix #655 - Add aggregation alignment option #801

merged 6 commits into from
Jul 27, 2021

Conversation

danni-m
Copy link
Collaborator

@danni-m danni-m commented Jul 22, 2021

No description provided.

@danni-m danni-m force-pushed the danni-m/aggregation_ts_alignment branch from d7e87ef to 1194bca Compare July 22, 2021 10:47
@danni-m
Copy link
Collaborator Author

danni-m commented Jul 22, 2021

@filipecosta90 @gkorland working on testing ATM.

@codecov
Copy link

codecov bot commented Jul 22, 2021 •
edited
Loading

Codecov Report

Merging #801 (de7142f) into master (bb75ab8) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   89.49%   89.60%   +0.11%     
==========================================
  Files          23       23              
  Lines        4112     4156      +44     
==========================================
+ Hits         3680     3724      +44     
  Misses        432      432
Impacted Files Coverage Δ
src/filter_iterator.c 99.03% <100.00%> (+0.03%) ⬆️
src/query_language.c 96.90% <100.00%> (+0.23%) ⬆️
src/tsdb.c 95.86% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb75ab8...de7142f. Read the comment docs.

This was referenced Jul 25, 2021
Closed
Closed
Closed
Closed
Closed
@danni-m danni-m force-pushed the danni-m/aggregation_ts_alignment branch from 8067dda to bb8bba2 Compare July 27, 2021 07:55
@filipecosta90 filipecosta90 linked an issue Jul 27, 2021 that may be closed by this pull request
aggregation + timebuckets, timestamps not bucket aligned #655
Closed
@filipecosta90 filipecosta90 added the enhancement New feature or request label Jul 27, 2021
filipecosta90
filipecosta90 requested changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM. Just some small suggestion on the docs to check WDYT about it @danni-m

docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
danni-m and others added 2 commits July 27, 2021 15:23
@danni-m
block ALIGN when no AGGREGATION args exists
c26ca3c
@danni-m @filipecosta90
Apply suggestions from code review
de7142f 
Co-authored-by: filipe oliveira <filipecosta.90@gmail.com>
@filipecosta90 filipecosta90 self-requested a review July 27, 2021 13:10
@filipecosta90 filipecosta90 added this to In progress in 1.6 via automation Jul 27, 2021
1.6 automation moved this from In progress to Reviewer approved Jul 27, 2021
@danni-m danni-m merged commit 6ac4738 into master Jul 27, 2021
1.6 automation moved this from Reviewer approved to Done Jul 27, 2021
@danni-m danni-m deleted the danni-m/aggregation_ts_alignment branch July 27, 2021 13:12
@filipecosta90 filipecosta90 linked an issue Jul 28, 2021 that may be closed by this pull request
Document aggregation ALIGN option #804
Closed
@gkorland gkorland mentioned this pull request Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipecosta90 filipecosta90 filipecosta90 approved these changes

@gkorland gkorland Awaiting requested review from gkorland

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
1.6
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document aggregation ALIGN option aggregation + timebuckets, timestamps not bucket aligned
2 participants
@danni-m @filipecosta90