Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ReverseRangeWithOptions and MultiReverseRangeWithOptions #70

Merged
merged 6 commits into from
Jul 23, 2020
Merged

Added ReverseRangeWithOptions and MultiReverseRangeWithOptions #70

merged 6 commits into from
Jul 23, 2020

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented Jul 22, 2020 •
edited
Loading

Based on user requests ( cc @stevesim101 ) I've quickly added ReverseRangeWithOptions and MultiReverseRangeWithOptions, and included examples on its usage:

@filipecosta90 filipecosta90 added the enhancement New feature or request label Jul 22, 2020
@codecov
Copy link

codecov bot commented Jul 22, 2020 •
edited
Loading

Codecov Report

Merging #70 into master will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   81.66%   81.97%   +0.30%     
==========================================
  Files           7        7              
  Lines         469      477       +8     
==========================================
+ Hits          383      391       +8     
  Misses         46       46              
  Partials       40       40
Impacted Files Coverage Δ
client.go 87.91% <100.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94fbf2d...66322de. Read the comment docs.

@filipecosta90 filipecosta90 changed the title [add] Added ReverseRangeWithOptions and MultiReverseRangeWithOptions Added ReverseRangeWithOptions and MultiReverseRangeWithOptions Jul 22, 2020
@filipecosta90 filipecosta90 self-assigned this Jul 22, 2020
@filipecosta90 filipecosta90 added this to In progress in 1.4 via automation Jul 22, 2020
This was referenced Jul 22, 2020
Closed
Closed
gkorland
gkorland suggested changes Jul 23, 2020
View reviewed changes
client.go Show resolved Hide resolved
client.go Show resolved Hide resolved
@filipecosta90 filipecosta90 merged commit 87b8303 into master Jul 23, 2020
1.4 automation moved this from In progress to Done Jul 23, 2020
@filipecosta90 filipecosta90 deleted the ts.revrange branch July 23, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkorland gkorland gkorland approved these changes

@danni-m danni-m Awaiting requested review from danni-m

@ashtul ashtul Awaiting requested review from ashtul

Assignees

@filipecosta90 filipecosta90

Labels
enhancement New feature or request
Projects
1.4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for TS.REVRANGE Support for TS.MREVRANGE
2 participants
@filipecosta90 @gkorland