Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: login-logout commands #351

Merged
merged 6 commits into from
Sep 8, 2021
Merged

Docs: login-logout commands #351

merged 6 commits into from
Sep 8, 2021

Conversation

bandantonio
Copy link
Contributor

What/Why/How?

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link
Contributor

@swapnilogale swapnilogale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let us split out this topic into individual login and logout pages

@bandantonio bandantonio changed the title Docs: added a combined page with login-logout commands instead of separate pages Docs: login-logout commands Sep 3, 2021
docs/commands/login.md Outdated Show resolved Hide resolved
docs/commands/login.md Outdated Show resolved Hide resolved
docs/commands/login.md Outdated Show resolved Hide resolved
docs/commands/logout.md Outdated Show resolved Hide resolved
ivana-isadora
ivana-isadora previously approved these changes Sep 7, 2021
Copy link
Contributor

@swapnilogale swapnilogale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bandantonio just a small style fix, but everything else looks good

@ivana-isadora ivana-isadora merged commit e892d32 into Redocly:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants