fix: fix deref logic for oas3.1 (#1767)

Redocly · Oct 11, 2021 · 4fb9c83 · 4fb9c83
1 parent 3b8d644
commit 4fb9c83
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/services/OpenAPIParser.ts b/src/services/OpenAPIParser.ts
@@ -195,7 +195,7 @@ export class OpenAPIParser {
     }
     if (mergeAsAllOf && keys.some((k) => k !== 'description' && k !== 'title' && k !== 'externalDocs')) {
       return {
-        allOf: [resolved, rest],
+        allOf: [rest, resolved],
       };
     } else {
       // small optimization

diff --git a/src/services/models/Schema.ts b/src/services/models/Schema.ts
@@ -80,7 +80,7 @@ export class SchemaModel {
     makeObservable(this);
 
     this.pointer = schemaOrRef.$ref || pointer || '';
-    this.rawSchema = parser.shallowDeref(schemaOrRef);
+    this.rawSchema = parser.deref(schemaOrRef, false, true);
     this.schema = parser.mergeAllOf(this.rawSchema, this.pointer, isChild);
 
     this.init(parser, isChild);
@@ -363,7 +363,7 @@ function buildFields(
 ): FieldModel[] {
   const props = schema.properties || {};
   const additionalProps = schema.additionalProperties;
-  const defaults = schema.default || {};
+  const defaults = schema.default;
   let fields = Object.keys(props || []).map((fieldName) => {
     let field = props[fieldName];
 
@@ -384,7 +384,7 @@ function buildFields(
         required,
         schema: {
           ...field,
-          default: field.default === undefined ? defaults[fieldName] : field.default,
+          default: field.default === undefined && defaults ? defaults[fieldName] : field.default,
         },
       },
       $ref + '/properties/' + fieldName,