Add nonce support #1566
Merged
Add nonce support #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyl
force-pushed
the
master
branch
2 times, most recently
from
cc0c845
to
3c4ece9
Compare
RomanHotsiy
previously requested changes
Apr 29, 2021
src/components/RedocStandalone.tsx
Outdated
| @@ -43,6 +45,10 @@ export class RedocStandalone extends React.PureComponent<RedocStandaloneProps> { | |||
|
|
|||
| const normalizedOpts = new RedocNormalizedOptions(options); | |||
|
|
|||
| if (normalizedOpts.nonce !== undefined) { | |||
| __webpack_nonce__ = normalizedOpts.nonce; | |||
There was a problem hiding this comment.
It may crash with ReferenceError in non-webpack env, e.g. when used by redoc-cli. We should add a check if the __webpack_nonce__ is defined.
There was a problem hiding this comment.
I had to use try/catch because __webpack_nonce__ is initially set to undefined making disambiguation between variable being declared but not set and not being declared at all very hard.
If you have a better way, I'm open to suggestion.
Okhoshi
force-pushed
the
add-nonce-support
branch
2 times, most recently
from
fe94fe6
to
56f3f46
Compare
|
@RomanHotsiy Thanks for the review ! I made the requested changes. |
|
ping @RomanHotsiy |
adamaltman
reviewed
Oct 6, 2021
Signed-off-by: Quentin Devos <4972091+Okhoshi@users.noreply.github.com>
Signed-off-by: Quentin Devos <4972091+Okhoshi@users.noreply.github.com>
Signed-off-by: Quentin Devos <4972091+Okhoshi@users.noreply.github.com>
Okhoshi
force-pushed
the
add-nonce-support
branch
from
56f3f46
to
8a4ec86
Compare
AlexVarchuk
approved these changes
Mar 23, 2022
AlexVarchuk
requested review from
RomanHotsiy
and removed request for
RomanHotsiy
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoc is broken if the page where it loads has CSP, in particular
style-srcdirectives. If inline styles are forbidden by the CSPs, the browser will refuse to load them, and Styled-Components won't work at all.Styled-components already support CSPs by reading a nonce from
__webpack_nonce__to apply it on every injected style tag. However, there's no way to configure this nonce with Redoc.This is what I added in this PR. The nonce can either be filled in the HTML with a
nonceattribute (similarly to other HTML elements like script or styles) or provided in the options object.