feat: theme add links textDecoration options #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanHotsiy
reviewed
Mar 22, 2022
README.md
Outdated
| @@ -292,7 +292,10 @@ You can use all of the following options with standalone version on <redoc> tag | |||
| * `links` | |||
| * `color`: # COMPUTED: colors.primary.main | |||
| * `visited`: # COMPUTED: typography.links.color | |||
| * `hover`: # COMPUTED: lighten(0.2 typography.links.color) | |||
| * `hover`: | |||
There was a problem hiding this comment.
I would not make a breaking change, instead I would add hoverTextDecoration and textDecoration
RomanHotsiy
requested changes
Mar 22, 2022
imagoiq
requested review from
AlexVarchuk and
zalesky
and removed request for
a team
zalesky
approved these changes
May 16, 2022
RomanHotsiy
approved these changes
May 16, 2022
|
@imagoiq Hi! Sorry for the huge delay. Thank you for your contribution to redoc 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options to define textDecoration for standard links or on hover.
Breaking change: