Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mis-nesting of aria roles on sidebar navigation #2050

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Mis-nesting of aria roles on sidebar navigation #2050

merged 1 commit into from
Jun 20, 2022

Conversation

ryan-garrett
Copy link
Contributor

The sidebar navigation uses menuItem but without the correct grouping parent role, instead using a navigation role.
The use of the navigation role on the ul also changes the role of that element from an implicit list to an explicit non-list, so rendering the implicit child list items without a correctly named parent.

Before:
Screenshot 2022-06-13 at 13 33 44

After:
Screenshot 2022-06-13 at 13 34 33

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

@ryan-garrett ryan-garrett requested a review from a team as a code owner June 13, 2022 12:34
@ryan-garrett ryan-garrett requested review from zalesky and Oprysk and removed request for a team June 13, 2022 12:34
@AlexVarchuk AlexVarchuk merged commit 7ca10da into Redocly:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants