-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Readme.md #1348
Updating Readme.md #1348
Conversation
fakela
commented
Aug 13, 2020
•
edited
edited
- comparison of features of the community edition vs. premium
- careers available mentions (link to Redoc.ly/careers)
- create-openapi-repo tool definition and link
- Redoc CLI definition and link
- A table to show the overview of Redocly Product
- Update Redoc CLI Readme
- Edits to the Readme documentation where it was needed
1) comparison of features of the community edition vs. premium
2. careers available mentions (link to Redoc.ly/careers)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a couple of notes for staff/owners reviewing this:
README.md
Outdated
- [redoc-cli](https://github.com/Redocly/redoc/blob/master/cli/README.md) with ability to bundle your docs into **zero-dependency** HTML file | ||
- [Redoc-cli](https://github.com/Redocly/redoc/blob/master/cli/README.md) with ability to bundle your docs into **zero-dependency** HTML file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the capitalisation as the project generally uses lowercase for actual packages (as is customary elsewhere) — I'd leave that to staff reviewer eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I suggest there could be some sort of terminology guide that guides contributors on the terms used and their correct format as it wasn't stated earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly.
I'm not sure where to start, if that's something to be covered under, dunno, contributing, or coc, or somewhere "officially" in the repo wiki or project boards? But having an official reference for styling and branding would help, as it seems that has evolved in the past somewhat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I think it can be covered in a part under the docs under contributing guidelines or on GitHub. Something that enables someone reference easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a WIP style guide here: https://github.com/Redocly/redoc/pull/1346/files#diff-cb328360a4c7e8b7b8073808479a3581 so let's see how that unfolds. Nonetheless it's neither complete in terms of addressing the various forms of product naming nor approved by the maintainers, so it's maybe a place to voice some open questions or feedback what to include in such style guide.
# redoc-cli | ||
# Redoc-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, prolly not the ideal way to capitalize, given the usage elsewhere in lowercase anyways…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be checked by the staff reviewers on the correct terminologies but i guess we would go with lowercase for consistency in the docs
cli/README.md
Outdated
**[ReDoc](https://github.com/Redocly/redoc)'s Command Line Interface** | ||
Redoc CLI is an open source tool that provides linting against a customizable ruleset, as well as bundling of the OpenAPI files into a single file. You can also preview the output of your docs with the Redocly API References through this tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds a bit confused with https://github.com/Redocly/openapi-cli — the redoc-cli is just the interface of the main Redoc, bundling/serving/previewing the output, so I'd rather not describe any "business" features here and keep the link to the repo root itself instead for more explanation (where such maintenance is provided, w/ up to date information).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, redoc-cli
https://github.com/Redocly/redoc/tree/master/cli and openapi-cli
https://github.com/Redocly/openapi-cl are different. The readme for the redoc-cli
was sparse so I added more information in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the ideal way would be to describe the difference that it makes from core redoc js, which is to "bundle your docs into zero-dependency HTML file", i. e. for a self-contained output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… and, yes, it's a live (--watch
) preview for any spec changes in real time, and also the way of server-side React pre-rendering, so it's kinda hard to describe just on its own, I agree;)
Maybe that's why the current docs are so sparse, as it serves several use cases for development, production and distribution that are inferred from other parts of the docs (or GH issues for that matter).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to draw a definition from the main documentation, thanks alot for your comments or maybe i can wait for the staff reviewers for their inputs
Co-authored-by: Jan Brašna <mail@janbrasna.com>
Co-authored-by: Jan Brašna <mail@janbrasna.com>
cc0c845
to
3c4ece9
Compare
Hello! We're cleaning up old docs-related PRs in this repository. As this one was part of trial day work and it hasn't been merged in the meantime, we're going to close it. You're always welcome to contribute to Redoc by opening a fresh pull request. :) |