feat：Chinese search is supported #2379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for the pull request, and sorry for the slow response. We don't have good support for other character sets in Redoc at the moment, and it will be difficult for us to adopt and support this feature in the long term. Therefore, with apologies, I am closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR aims to add support for Chinese search functionality in ReDoc. Currently, ReDoc supports searching API documentation using English keywords, but this feature request proposes extending the search capability to include Chinese language support. With this enhancement, users will be able to search for API endpoints, methods, and descriptions using both English and Chinese keywords.
Why:
Adding Chinese search support is important to cater to a wider user base, especially in regions where Chinese is the primary language. By enabling users to search for API documentation using Chinese keywords, ReDoc becomes more accessible and user-friendly for Chinese-speaking developers. This enhancement aligns with the goal of making ReDoc a versatile and inclusive tool for API documentation.
How:
Currently, there are only Node.js and WebAssembly-based Chinese word segmentation libraries available on npm.
In order to support Chinese search. So you hid the English word segmentation functionality
Tests
Screenshots (optional)
issue：#2373 (comment)
Check yourself