Add JSON Schema misconfigurations rules

[adamaltman]

• https://apisyouwonthate.slack.com/archives/C0HGLHK0B/p1712304065817669
• https://apisyouwonthate.slack.com/archives/C0HGLHK0B/p1712405606458459

[tatomyr]

Left a few comments.

[tatomyr]

Good addition, thanks!

[lornajane]

Nice - and I immediately caught a problem with the Museum API while testing this :)

[jeremyfiel]

Nice!

did you omit severity and message on purpose?

[jeremyfiel]

this throws a false positive with the following schema

  rule/json-schema-array-misconfiguration:
    subject: 
      type: Schema
    where: 
      - subject: 
          type: Schema
          property: type
        assertions:  
          const: array
    assertions: 
      disallowed: 
        - properties

type: object
properties:
  thing:
    type: array
    items:
      type: object // if this line is present, the error goes away. But this is not mandatory by the JSON Schema spec. 
      properties: {}

also throws with this schema

allOf:
- type: object
- properties: {}

[jeremyfiel]

This rule throws a false positive

  rule/json-schema-object-with-items:
    severity: warn
    message: '"items" SHOULD NOT be used with "type: object"'
    suggest: 
      - properties
    subject:
      type: Schema
    where:
      - subject:
          type: Schema
          property: type
        assertions:
          const: object
    assertions:
      disallowed:
        - items

type: object
properties:
  thing3:
    items:
      properties: {}

[adamaltman]

These are good points and might be added to the README. However, if I'm the type of person who has advanced lint rules, I'm probably the type of person who requires type: object to be explicitly defined when defining properties. (At least, I'm that type of person.)

I did intentionally omit message and severity (defaults to error).