fix: prevent loadConfig from failing in browser env and do not sent a…

…uth requests (#1552)

.changeset/young-apes-sell.md

@@ -0,0 +1,5 @@
+---
+"@redocly/openapi-core": patch
+---
+
+Improved loading of configuration files in environments different from Node.js.

packages/core/src/config/__tests__/load.test.ts

@@ -13,10 +13,9 @@ const path = require('path');
 describe('loadConfig', () => {
   it('should resolve config http header by US region', async () => {
     jest
-      .spyOn(RedoclyClient.prototype, 'getTokens')
-      .mockImplementation(() =>
-        Promise.resolve([{ region: 'us', token: 'accessToken', valid: true }])
-      );
+      .spyOn(RedoclyClient.prototype, 'getAllTokens')
+      .mockImplementation(() => [{ region: 'us', token: 'accessToken' }]);
+    jest.spyOn(RedoclyClient.prototype, 'hasTokens').mockImplementation(() => true);
     const config = await loadConfig();
     expect(config.resolve.http.headers).toStrictEqual([
       {
@@ -36,10 +35,9 @@ describe('loadConfig', () => {
 
   it('should resolve config http header by EU region', async () => {
     jest
-      .spyOn(RedoclyClient.prototype, 'getTokens')
-      .mockImplementation(() =>
-        Promise.resolve([{ region: 'eu', token: 'accessToken', valid: true }])
-      );
+      .spyOn(RedoclyClient.prototype, 'getAllTokens')
+      .mockImplementation(() => [{ region: 'eu', token: 'accessToken' }]);
+    jest.spyOn(RedoclyClient.prototype, 'hasTokens').mockImplementation(() => true);
     const config = await loadConfig();
     expect(config.resolve.http.headers).toStrictEqual([
       {

packages/core/src/config/load.ts

@@ -1,15 +1,15 @@
 import * as fs from 'fs';
 import * as path from 'path';
 import { RedoclyClient } from '../redocly';
-import { isEmptyObject, doesYamlFileExist } from '../utils';
+import { isEmptyObject } from '../utils';
 import { parseYaml } from '../js-yaml';
 import { Config, DOMAINS } from './config';
 import { ConfigValidationError, transformConfig } from './utils';
 import { resolveConfig, resolveConfigFileAndRefs } from './config-resolvers';
 import { bundleConfig } from '../bundle';
 
 import type { Document } from '../resolve';
-import type { RegionalTokenWithValidity } from '../redocly/redocly-client-types';
+import type { RegionalToken, RegionalTokenWithValidity } from '../redocly/redocly-client-types';
 import type { RawConfig, RawUniversalConfig, Region } from './types';
 import type { BaseResolver, ResolvedRefMap } from '../resolve';
 
@@ -25,7 +25,7 @@ async function addConfigMetadata({
   rawConfig: RawConfig;
   customExtends?: string[];
   configPath?: string;
-  tokens?: RegionalTokenWithValidity[];
+  tokens?: RegionalToken[];
   files?: string[];
   region?: Region;
   externalRefResolver?: BaseResolver;
@@ -102,8 +102,8 @@ export async function loadConfig(
   } = options;
   const rawConfig = await getConfig({ configPath, processRawConfig, externalRefResolver });
 
-  const redoclyClient = new RedoclyClient();
-  const tokens = await redoclyClient.getTokens();
+  const redoclyClient = isEmptyObject(fs) ? undefined : new RedoclyClient();
+  const tokens = redoclyClient && redoclyClient.hasTokens() ? redoclyClient.getAllTokens() : [];
 
   return addConfigMetadata({
     rawConfig,
@@ -119,7 +119,7 @@ export async function loadConfig(
 export const CONFIG_FILE_NAMES = ['redocly.yaml', 'redocly.yml', '.redocly.yaml', '.redocly.yml'];
 
 export function findConfig(dir?: string): string | undefined {
-  if (!fs.hasOwnProperty('existsSync')) return;
+  if (!fs?.hasOwnProperty?.('existsSync')) return;
   const existingConfigFiles = CONFIG_FILE_NAMES.map((name) =>
     dir ? path.resolve(dir, name) : name
   ).filter(fs.existsSync);
@@ -141,7 +141,9 @@ export async function getConfig(
   } = {}
 ): Promise<RawConfig> {
   const { configPath = findConfig(), processRawConfig, externalRefResolver } = options;
-  if (!configPath || !doesYamlFileExist(configPath)) return {};
+  if (!configPath || !['.yaml', '.yml'].includes(path.extname(configPath))) {
+    return {};
+  }
   try {
     const { document, resolvedRefMap } = await resolveConfigFileAndRefs({
       configPath,

packages/core/src/utils.ts

@@ -206,7 +206,7 @@ export function isCustomRuleId(id: string) {
 export function doesYamlFileExist(filePath: string): boolean {
   return (
     (extname(filePath) === '.yaml' || extname(filePath) === '.yml') &&
-    fs.hasOwnProperty('existsSync') &&
+    fs?.hasOwnProperty?.('existsSync') &&
     fs.existsSync(filePath)
   );
 }