Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle $ref in the joining path parameters #1034

Merged
merged 7 commits into from
Mar 30, 2023

Conversation

IgorKarpiuk
Copy link
Contributor

What/Why/How?

Handle $ref in the joining path parameters

Reference

Closes: #1018

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@IgorKarpiuk IgorKarpiuk self-assigned this Mar 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 73.76% 3437/4660
🟡 Branches 64.85% 1959/3021
🟡 Functions 66.17% 579/875
🟡 Lines 73.78% 3196/4332
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / join.ts
59.2%
41.9% (-1.71% 🔻)
58.82% 60.45%

Test suite run success

566 tests passing in 85 suites.

Report generated by 🧪jest coverage report action from 444ce57

@IgorKarpiuk IgorKarpiuk marked this pull request as ready for review March 29, 2023 13:24
@IgorKarpiuk IgorKarpiuk requested a review from a team as a code owner March 29, 2023 13:24
@IgorKarpiuk IgorKarpiuk merged commit 5cf1e98 into main Mar 30, 2023
@IgorKarpiuk IgorKarpiuk deleted the fix/join_path_parameters branch March 30, 2023 07:51
@SmoliyY SmoliyY mentioned this pull request Mar 30, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with joining path parameters
3 participants