chore: add performance benchmark with hyperfine #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatomyr
force-pushed
the
chore/add-benchmark-action
branch
from
6460988
to
43c1eb7
Compare
Coverage report
Test suite run success585 tests passing in 85 suites. Report generated by 🧪jest coverage report action from 35c4bbe |
tatomyr
force-pushed
the
chore/add-benchmark-action
branch
from
43c1eb7
to
955c836
Compare
|
🚀 |
tatomyr
force-pushed
the
chore/add-benchmark-action
branch
2 times, most recently
from
c6c118a
to
aebeb3e
Compare
|
|
🚀 |
tatomyr
force-pushed
the
chore/add-benchmark-action
branch
2 times, most recently
from
a724277
to
06a616a
Compare
|
tatomyr
force-pushed
the
chore/add-benchmark-action
branch
2 times, most recently
from
bc14580
to
bbfeed0
Compare
|
tatomyr
force-pushed
the
chore/add-benchmark-action
branch
from
bbfeed0
to
b650185
Compare
|
tatomyr
force-pushed
the
chore/add-benchmark-action
branch
from
b650185
to
c22f858
Compare
|
tatomyr
force-pushed
the
chore/add-benchmark-action
branch
3 times, most recently
from
c440127
to
5068589
Compare
tatomyr
force-pushed
the
chore/add-benchmark-action
branch
from
5068589
to
0cf8335
Compare
RomanHotsiy
reviewed
May 19, 2023
Comment on lines
+28
to
+29
| - name: Install External | ||
| run: npm i -g hyperfine @redocly/cli@latest |
There was a problem hiding this comment.
should it compare with the latest or with the version from main?
I think latest is fine for now but would be great to check-out main branch and compare it to it somehow in the future.
There was a problem hiding this comment.
Yes, comparing to main would be better, but I haven't found a simple and reliable solution to this yet. Will check how this approach works first, and then we can decide how to evolve it.
tatomyr
force-pushed
the
chore/add-benchmark-action
branch
from
36248c8
to
35c4bbe
Compare
RomanHotsiy
approved these changes
May 22, 2023
IgorKarpiuk
approved these changes
May 22, 2023
SmoliyY
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Added performance benchmarking using
hyperfine.Reference
Testing
Screenshots (optional)
Check yourself
Security