-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use prettier more #1109
chore: use prettier more #1109
Conversation
|
Coverage report
Test suite run success587 tests passing in 85 suites. Report generated by 🧪jest coverage report action from 4d9df11 |
12ad2aa
to
cb530e3
Compare
cb530e3
to
4d9df11
Compare
I really like this! But how can we maintain the standards on the project? I think having it as a precommit requirement might be too much for a public project, do we or could we run the check task in CI? |
@lornajane yeah, the same task in CI we're currently running for ts/js files, but extended for yaml/json. See the changes in package.json: https://github.com/Redocly/redocly-cli/pull/1109/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tatomyr (and prettier!). A good quality improvement IMO.
What/Why/How?
Ran Prettier on yaml and json files.
I believe we'll benefit from enforcing consistency wherever we can automate it.
Changes mostly located in test files, so I also updated the snapshots.
Also I'd suggest covering .md files after merging large docs MRs.
Reference
Testing
Screenshots (optional)
Check yourself
Security