Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add spec-strict-refs rule to rulesets #1124

Merged
merged 1 commit into from
Jun 7, 2023
Merged

chore: add spec-strict-refs rule to rulesets #1124

merged 1 commit into from
Jun 7, 2023

Conversation

IgorKarpiuk
Copy link
Contributor

What/Why/How?

Add spec-strict-refs rule to rulesets

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@IgorKarpiuk IgorKarpiuk requested a review from a team as a code owner June 7, 2023 07:41
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.239 ± 0.034 1.193 1.287 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.242 ± 0.024 1.199 1.279 1.00 ± 0.03

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 73.29% 3518/4800
🟡 Branches 64.95% 2007/3090
🟡 Functions 65.7% 590/898
🟡 Lines 73.34% 3274/4464

Test suite run success

588 tests passing in 86 suites.

Report generated by 🧪jest coverage report action from a2ca2e5

@IgorKarpiuk IgorKarpiuk merged commit 67118db into main Jun 7, 2023
9 checks passed
@IgorKarpiuk IgorKarpiuk deleted the fix/add_spec-strict-refs_rule_to_recommended branch June 7, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatomyr tatomyr tatomyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IgorKarpiuk @tatomyr