Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deploy docker container to GitHub registry #1147

Merged
merged 9 commits into from
Jul 5, 2023

Conversation

IgorKarpiuk
Copy link
Contributor

@IgorKarpiuk IgorKarpiuk commented Jul 3, 2023

What/Why/How?

Deploy docker container to GitHub registry

Reference

Closes: #875

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@IgorKarpiuk IgorKarpiuk self-assigned this Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Command Mean [s] Min [s] Max [s] Relative
REDOCLY_TELEMETRY=off redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.303 ± 0.017 1.266 1.328 1.00
REDOCLY_TELEMETRY=off redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.326 ± 0.034 1.266 1.368 1.02 ± 0.03

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 74.43% 3708/4982
🟡 Branches 65.41% 2059/3148
🟡 Functions 66.67% 616/924
🟡 Lines 74.49% 3458/4642

Test suite run success

613 tests passing in 88 suites.

Report generated by 🧪jest coverage report action from 3053445

@IgorKarpiuk IgorKarpiuk marked this pull request as ready for review July 4, 2023 10:08
@IgorKarpiuk IgorKarpiuk requested a review from a team as a code owner July 4, 2023 10:08
@lornajane
Copy link
Collaborator

Do we need to have any metadata, descriptions, tags, or documentation such as installation/usage instructions for the registry?

@IgorKarpiuk
Copy link
Contributor Author

@lornajane I think we just need to update the docs here

@IgorKarpiuk IgorKarpiuk merged commit 60ed5a4 into main Jul 5, 2023
11 checks passed
@IgorKarpiuk IgorKarpiuk deleted the chore/github-registry branch July 5, 2023 14:51
@lornajane
Copy link
Collaborator

Are you updating those, or do you want to give me some clues on how I should do that? Let's capture it as a followup (non-GA) issue

@tatomyr
Copy link
Contributor

tatomyr commented Jul 5, 2023

@lornajane we are going to prepare a small draft.

@tatomyr tatomyr mentioned this pull request Jul 5, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish docker container to GitHub Packages
4 participants