Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve detection accuracy on no-server-example.com rule #1270

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

adamaltman
Copy link
Member

What/Why/How?

Improves the detection accuracy for the no-server-example.com rule.

Reference

Closes #1269

Testing

Added tests and had to adjust multiple tests which used variants of example.com.

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@adamaltman adamaltman requested a review from a team as a code owner September 22, 2023 02:36
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: f994214

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.595 ± 0.044 1.517 1.684 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.611 ± 0.052 1.541 1.687 1.01 ± 0.04

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.9% 3999/5269
🟡 Branches 65.82% 2130/3236
🟡 Functions 67.92% 648/954
🟡 Lines 76.09% 3748/4926

Test suite run success

636 tests passing in 93 suites.

Report generated by 🧪jest coverage report action from f994214

@adamaltman adamaltman merged commit eb82725 into main Sep 22, 2023
28 checks passed
@adamaltman adamaltman deleted the no-example-com branch September 22, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-server-example.com
3 participants