feat: extend split and join commands to produce JSON output #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 39a5c8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage report
Test suite run success645 tests passing in 93 suites. Report generated by 🧪jest coverage report action from 39a5c8a |
tatomyr
reviewed
Oct 19, 2023
tatomyr
reviewed
Oct 19, 2023
tatomyr
reviewed
Oct 19, 2023
IgorKarpiuk
force-pushed
the
feat/split-and-join-output
branch
from
8e4da06
to
83d854b
Compare
roman-sainchuk
approved these changes
Oct 23, 2023
docs/commands/join.md
Outdated
There was a problem hiding this comment.
Dont we need to update docs for split command as well ?
There was a problem hiding this comment.
I don't think we need to update the docs. This feature was originally reported as a bug, the split command doesn't mention what it can output (but it only supported YAML until now) and a user expected it to work with JSON too.
lornajane
approved these changes
Oct 23, 2023
Co-authored-by: Andrew Tatomyr <andrew.tatomyr@redocly.com>
Co-authored-by: Andrew Tatomyr <andrew.tatomyr@redocly.com>
Co-authored-by: Andrew Tatomyr <andrew.tatomyr@redocly.com>
Co-authored-by: Lorna Jane Mitchell <github@lornajane.net>
IgorKarpiuk
force-pushed
the
feat/split-and-join-output
branch
from
2c64201
to
39a5c8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Extend
splitandjoincommands to optionally produce JSON output.Split
Determine the output format by the extension of the input file, if the extension is not supported use
yamlSupported file extensions:
json,yaml,ymlJoin
Determine the output format by the extension of the file from
outputoption, if output option is not provided use extension of first entry point, if extension not supported useyaml.Supported file extensions:
json,yaml,ymlReference
Related: #1205
Testing
Screenshots (optional)
Check yourself
Security