Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating json-schema tag #1549

Merged
merged 3 commits into from
May 10, 2024
Merged

Updating json-schema tag #1549

merged 3 commits into from
May 10, 2024

Conversation

TaylorKrusen
Copy link
Contributor

What/Why/How?

Updates the json-schema tag to reflect new format.

Reference

This change impacts downstream documentation.

Testing

Previewed change by updating the tag in locally running version of downstream docs.

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@TaylorKrusen TaylorKrusen requested a review from a team as a code owner May 7, 2024 16:56
Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: 81f82af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 7, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 971.2 ± 28.4 936.5 1029.0 1.02 ± 0.04
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 954.0 ± 18.9 928.5 988.5 1.00

Copy link
Contributor

github-actions bot commented May 7, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.02% 4452/5780
🟡 Branches 67.5% 2463/3649
🟡 Functions 70.64% 741/1049
🟡 Lines 77.22% 4187/5422

Test suite run success

734 tests passing in 102 suites.

Report generated by 🧪jest coverage report action from 81f82af

Copy link
Collaborator

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently updating this same issue on the marketing site. @TaylorKrusen could you update your PR according to Roman's advice please?

Copy link
Contributor

@HCloward HCloward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reflects the new format from Roman's comment.

@TaylorKrusen TaylorKrusen merged commit dbbbad8 into main May 10, 2024
32 checks passed
@TaylorKrusen TaylorKrusen deleted the json-schema-tag-update branch May 10, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants