Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if the config file exists #1555

Merged
merged 2 commits into from
May 9, 2024

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented May 9, 2024

What/Why/How?

Return a default fallbeck if there is no config file for the provided path.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr requested review from a team as code owners May 9, 2024 14:53
Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: b9e97d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tatomyr tatomyr self-assigned this May 9, 2024
@tatomyr tatomyr requested a review from RomanHotsiy May 9, 2024 14:53
Copy link
Contributor

github-actions bot commented May 9, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 972.6 ± 20.2 946.8 1017.7 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 980.3 ± 22.7 941.7 1014.4 1.01 ± 0.03

Copy link
Contributor

github-actions bot commented May 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.02% 4452/5780
🟡 Branches 67.5% 2463/3649
🟡 Functions 70.64% 741/1049
🟡 Lines 77.22% 4187/5422
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / load.ts
87.72% (-1.17% 🔻)
80.36% 100%
88.89% (-1.31% 🔻)
🟢
... / config-resolvers.ts
83.43% 73.38% 100% 84.05%

Test suite run success

734 tests passing in 102 suites.

Report generated by 🧪jest coverage report action from b9e97d7

.changeset/hot-vans-smile.md Outdated Show resolved Hide resolved
Co-authored-by: Lorna Jane Mitchell <github@lornajane.net>
@tatomyr tatomyr merged commit 71e4910 into main May 9, 2024
32 checks passed
@tatomyr tatomyr deleted the fix/check-if-the-config-file-exists branch May 9, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants