Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add checks for browser env #1565

Merged
merged 2 commits into from
May 23, 2024
Merged

chore: add checks for browser env #1565

merged 2 commits into from
May 23, 2024

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented May 22, 2024

What/Why/How?

  • Added checks for browser environment when using Node.js features in openapi-core.
  • Removed needless try...catch block.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr requested a review from a team as a code owner May 22, 2024 07:05
@tatomyr tatomyr self-assigned this May 22, 2024
Copy link

changeset-bot bot commented May 22, 2024

⚠️ No Changeset found

Latest commit: 55ba1eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 22, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 952.0 ± 15.9 925.1 985.3 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 970.3 ± 26.2 932.3 1012.1 1.02 ± 0.03

Copy link
Contributor

github-actions bot commented May 22, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.25% 4481/5801
🟡 Branches 67.48% 2467/3656
🟡 Functions 70.86% 744/1050
🟡 Lines 77.45% 4214/5441
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / load.ts
89.29% (+1.57% 🔼)
79.63% 100%
90.38% (+1.5% 🔼)

Test suite run success

735 tests passing in 102 suites.

Report generated by 🧪jest coverage report action from 55ba1eb

Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since @RomanHotsiy has approved

@tatomyr tatomyr merged commit f37f628 into main May 23, 2024
32 checks passed
@tatomyr tatomyr deleted the chore/check-browser-env branch May 23, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants