feat: response-contains-property built-in rule #535
Conversation
| return { | ||
| Response: { | ||
| skip: (_response, key) => { | ||
| return !['200', '201', '202'].includes(key.toString()); |
There was a problem hiding this comment.
What do these numbers mean?
There was a problem hiding this comment.
@tatomyr
HTTP status codes, we omit all statuses except those listed above, because those requests have no response content.
There was a problem hiding this comment.
Well, they may have response content but may be errors, and that's why they aren't applicable either.
204 - no content
4XX - bad requests
5XX - server errors
It's common that things like 4XX have different properties.
There was a problem hiding this comment.
Same as #537 (comment)
But here also different mime types are in play, so I'm not sure what to suggest yet.
@adamaltman do you have some ideas?
There was a problem hiding this comment.
Yes, I think the 2XX, 4XX configuration options is a good idea.
|
Closing this since the changes are incorporated into #537 |
What/Why/How?
Closes #389
Check yourself
Security