Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GcmNotificationPriority serialization #679

Closed
grishin opened this issue Apr 7, 2016 · 0 comments
Closed

GcmNotificationPriority serialization #679

grishin opened this issue Apr 7, 2016 · 0 comments

Comments

@grishin
Copy link

grishin commented Apr 7, 2016

What version of PushSharp are you using?

4.0.4

Describe your issue:

I'm having trouble sending pushes to Android 6.0 phone with "high" priority setting. In the code (https://github.com/Redth/PushSharp/blob/master/PushSharp.Google/GcmNotification.cs#L142) i've found that GcmNotificationPriority enum is serialized as int (5, 10) not as strings ("normal", "high") as google's docs require https://developers.google.com/cloud-messaging/concept-options#setting-the-priority-of-a-message.

[JsonProperty ("priority"), JsonConverter(typeof(StringEnumConverter))]
public GcmNotificationPriority? Priority { get; set; }

What are the steps required to reproduce this issue?

Please provide any Exception Stack Traces

@Redth Redth closed this as completed in cbfa73b Apr 7, 2016
Redth added a commit that referenced this issue May 10, 2016
This fixes #679 where the priority was being serialized as  a number instead of the text as per Google's docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant