Cache the reader instance

Previously this was being recreated repeatedly so the set options weren't actually being used for analyzing frames.
Redth · Aug 30, 2022 · 8db0e5f · 8db0e5f
1 parent 92e06c7
commit 8db0e5f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/ZXing.Net.MAUI/CameraBarcodeReaderViewHandler.cs b/ZXing.Net.MAUI/CameraBarcodeReaderViewHandler.cs
@@ -38,8 +38,10 @@ public CameraBarcodeReaderViewHandler(PropertyMapper mapper = null) : base(mappe
 
 		CameraManager cameraManager;
 
+		Readers.IBarcodeReader barcodeReader;
+
 		protected Readers.IBarcodeReader BarcodeReader
-			=> Services.GetService<Readers.IBarcodeReader>();
+			=> barcodeReader ??= Services.GetService<Readers.IBarcodeReader>();
 
 		protected override NativePlatformCameraPreviewView CreatePlatformView()
 		{

diff --git a/ZXing.Net.MAUI/ZXingBarcodeReader.cs b/ZXing.Net.MAUI/ZXingBarcodeReader.cs
@@ -2,8 +2,6 @@
 
 namespace ZXing.Net.Maui.Readers
 {
-
-
 	public class ZXingBarcodeReader : Readers.IBarcodeReader
 	{
 		BarcodeReaderGeneric zxingReader;
@@ -21,9 +19,9 @@ public BarcodeReaderOptions Options
 			set
 			{
 				options = value;
-				zxingReader.Options.PossibleFormats = Options.Formats.ToZXingList();
-				zxingReader.Options.TryHarder = Options.TryHarder;
-				zxingReader.AutoRotate = Options.AutoRotate;
+				zxingReader.Options.PossibleFormats = options.Formats.ToZXingList();
+				zxingReader.Options.TryHarder = options.TryHarder;
+				zxingReader.AutoRotate = options.AutoRotate;
 			}
 		}