Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogFragment. #25

Closed
slackshot opened this issue Mar 14, 2013 · 16 comments
Closed

DialogFragment. #25

slackshot opened this issue Mar 14, 2013 · 16 comments
Labels

Comments

@slackshot
Copy link

When I use a DialogFragment (Monodroid), calling the ZXing component does not show the camera view.

@Redth
Copy link
Owner

Redth commented Mar 19, 2013

Do you have a bit of repro code you can share for the DialogFragment calling it?

@slackshot
Copy link
Author

Actually, I might have entirely been mistaken. Had some weird period in the app, where I was integrating the Support Library in Android so I could still use fragments on the lower API.. once that was all fully hashed out, things cleared up.. Not sure how I was getting the app to build during that time frame, but now it works. Looks like I have to go RedLaserSDK though.. even when I pull down to just the target barcode type with scanning options, the translation is just too slow. I can and do use it with my non-profit projects, because they don't have the budget, but this isn't one of those cases. -sighs- I do love the code from this project and I'm not criticizing it's usefulness at all.. performance just seems to be variable. Have a tablet where it works just fine.. then I have a couple phones / tablets where it's just.. not good. And since I can't control the hardware fragmentation with Android.. I just have to keep it tight where I need to, and loose where I can.

@Redth
Copy link
Owner

Redth commented Mar 19, 2013

Android is known issue for performance right now... I am working on it, so stay tuned!

@slackshot
Copy link
Author

Well, when you do get around to it, I know that 250 kids who use a kiosk system I built in Monodroid and the staff of that non-profit will be grateful. : ) Keep fighting the good fight.

@slackshot
Copy link
Author

http://slackshotindustries.blogspot.com/2013/01/maybe-i-get-ahead-of-myself-little.html If you wanted to see my post on it. -laughs- Anyways, Sorry to mug up your issues board.

Redth added a commit that referenced this issue Mar 19, 2013
Now using the reader the way @micjahn suggests for speed (besides
turning off Auto Rotate).  Stopped using a smaller rectangle of the
preview image for analysis, and for now using the entire image to
analyze.  I think there's a problem with the data rect expecting
portrait and image being landscape.  Also slowed down how often frames
are analyzed so the phone should do less work.  This should help #16 and
also #25
@Redth
Copy link
Owner

Redth commented Mar 19, 2013

@slackshot that's awesome! Love to see uses like this, you should have shared this way sooner :)

Anyway, I've added some more changes that should hopefully help the performance if you wouldn't mind testing!

@slackshot
Copy link
Author

Heck man, I'll test anything you want.. Pulling down the code now. : )

@slackshot
Copy link
Author

Noticeable improvement. Wow. Took a while to get a hit on the data in the barcode.. still longer than I'd like for user experience, but wow. Definitely better.

@slackshot
Copy link
Author

It's variable a bit still.. this last pick up for the barcode was almost like redlaser.

@slackshot
Copy link
Author

Yeah, publish that for your Xamarin component.. That is seriously 10 times better than it used to be.

@Redth
Copy link
Owner

Redth commented Mar 19, 2013

Will be doing that, thanks :)

@slackshot
Copy link
Author

You just made my day.. I think this is awesome enough that I can just leave out Redlaser. And I can go back and fix up Youth Impact's system. Yay! Thank you thank you thank you. : )

@Redth
Copy link
Owner

Redth commented Mar 19, 2013

Great :) What I'd like to do is add some support to adjust the delay between decoding/analyzing the preview. I had bumped it up to 250ms in this latest code (from 150ms). Longer delays between analysis obviously improves performance from a decoding standpoint, but makes scanning 'seem' a bit longer if you focus right at the end of the last analysis, and then have to wait the 250ms for the next analysis. Ultimately this parameter will be configurable.

@slackshot
Copy link
Author

If you wanted to do me a favor, get my MonoGCP repo some attention. Doing the same thing with a Xamarin Component for it. Probably needs more features, but hey.. it's code that's useful.

@Redth
Copy link
Owner

Redth commented Mar 20, 2013

@slackshot updated component for the xamarin component store is pending approval. Also added the interval configuration to master.

I'd love to check out Mono GCP, just haven't had a use case for it yet....

@slackshot
Copy link
Author

Aweesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants