Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX - Forms Android SurfaceView when IsScanning is set to False th… #725

Closed
wants to merge 1 commit into from
Closed

BUGFIX - Forms Android SurfaceView when IsScanning is set to False th… #725

wants to merge 1 commit into from

Conversation

tomasz23
Copy link

…e camera is disabled but never enabled when IsScanning is to True anytime after disable state

updated sample Forms to include buttons to turn off camera and then on as described in documentation by using IsScanning

…e camera is disabled but never enabled when IsScanning is to True

updated sample Forms to include buttons to turn off camera and then on as described in documentation by using IsScanning
@tomasz23
Copy link
Author

Tested on Android 6.0 and 7.1

@knocte
Copy link
Contributor

knocte commented Sep 3, 2018

@tomasz23 this commit seems to try to address 2 issues at the same time, right? Why does it add three buttons? (these are not mentioned in the commit message so it's difficult to know what is the intended purpose of them)

@tomasz23
Copy link
Author

tomasz23 commented Sep 3, 2018

This address only one issue 0 when IsScanning is switched the SurfaceView is not reinitialized after it was destroyed by setting IsScanning to false. The demo I adjusted to illustrate the problem and that the fix resolved this problem. Original sample never actually set IsScanning=False and the back to True thus it was not noticed that SurfaceView would never be regenerated.

@Redth Redth mentioned this pull request Mar 12, 2020
@Redth
Copy link
Owner

Redth commented Mar 12, 2020

Thanks for your contribution! I've done a lot of work to modernize the ZXing.Net.Mobile code base and have merged those changes into master. I've included fixes from your PR manually. Please open a new issue or PR if you have more suggestions or changes. Thank you so much for your help!

@Redth Redth closed this Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants