Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Refresh Rate (FPS) issues on certain android devices #909

Merged
merged 1 commit into from Jan 18, 2021

Conversation

Strifex
Copy link
Contributor

@Strifex Strifex commented Jun 4, 2020

Update refresh rate selection to choose the highest FPS with the widest range in order to improve compatibility across devices and avoid selecting obscenely low fps values.

The purpose of this is to help mitigate issues like #492

Essentially on some android devices like some variants of the samsung galaxy J7 the camera displays a possible refresh value of 7000-7000 which under the current algorithm will always be selected. However, for the purposes of scanning that makes the refresh rate far too low and the device lags and struggled to scan the image. This change will adjust the algorithm to keep selecting similar values as the current one to maintain high compatibility but avoid the extremely low refresh rate options.

Samsung J7 FPS Ranges:

7000-7000
15000-15000
24000-24000
8000-30000
10000-30000
15000-30000
30000-30000

Current Selected Refresh Range (before this change):
7000-7000

New Selected Refresh Range (with this change):
8000-30000

…st range in order to improve compatibility across devices and avoid selecting obscenely low fps values.
@Strifex
Copy link
Contributor Author

Strifex commented Jun 4, 2020

@Redth btw - I know this is a selfish request but if you agree with this change and decide to merge it please move it into the next 3.0 beta build....my team has been using a custom branch of a version of this library from years ago because of this bug and this is the last issue in the official builds preventing us from switching back to the official releases :) Thanks again for starting to give this library some love again - its greatly appreciated!

@Redth Redth merged commit 73957be into Redth:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants