-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple spaces get lost in many UIs #26
Comments
On one project we're using Maybe |
I personally prefer whitespace over
|
I'd love to hear thoughts from @isidore, @mscottford, or others on this proposal. |
Just for comparison:
|
And one more:
|
My initial reaction is to wonder about the importance of the extra spaces. It appears that they are primarily needed to help the eye notice when
I'm curious about y'all's thoughts on that. |
Hm. I'm losing glance-ability with any of the options that use periods. My number 1 priority with this encoding is for someone to quickly glance down the column and, without reading, see the high-risk commits. I really want ** and !! to stand out. I'd like R to stand out some from r, but that is less important. The underscores work a little better than periods for me at a glace, though still not as good as spaces (even with the hyphen). |
What advantage do you see to having these as delimiters? Personally I don't get a psychological difference between delimiter and trailing marker. What are you noticing that I miss? |
My initial thought along those lines was that if there were start and stop delimiters, instead of fixed width/padding, then the mechanism could employ longer terms instead of just single characters, and that this might increase understanding amongst other teams. Perhaps something similar to Gitmoji, but instead of relying on the emoji names, aliases are created. I trimmed that back to the proposal that I sent in because I suspected that would be more drastic a change than was requested. That original idea looked something like this:
Which I suspected would not meet the goals that you all have. However, this approach allows someone to very quickly scan the list for I'm noticing that this preference of having a start and stop character stems from me not being a very big fan of meaningful whitespace. In addition to GitHub not rendering the extra spaces, I notice that I often forget to actually type them out. :) It's completely possible that this approach is incompatible with the goals of this effort. :) I'm also noticing that the suggestion that I've made above is influenced by a desire to avoid a single value having two different meanings ( |
I'm going to close this with the adoption of I see the value of your proposal, Scott, but yeah, I don't find it to meet the goals of this notation. I'm explicitly looking for a columnar format, as that makes vertical scanning easy. Gitmoji would account for that, as long as the tooling supported it (and there was decent auto-complete when writing the commit message). I'd take your proposal over mine if those were both true! |
We currently use three spaces for safer commits (
r Extract Method
) so that they align well with unsafe commits (R!! Cleaned up the core logic
) but that only works with fixed-width display. Many UIs merge those spaces, like this in GitHub:The text was updated successfully, but these errors were encountered: