-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fortran intrinsics tests fail #757
Comments
Hi Julien, Thanks for the bug report. This is a GCC error as far as we are concerned. LAPACK has CLADIV / ZLADIV that implements no-unnecessary-under/overflow complex divisions (based off real divisions), but it would be nice if compilers would give this feature from the fortran complex division operator, so that we do not have to rely on our own CLADIV / ZLADIV. I am fine with your PR which proposes to disable the compiler checks by default. Note: I can reproduce the failure on my laptop. I also have 12.2.0. Note: GCC passes many tests. We only report the failed tests, (so 4 in this case,) but many tests are passing. What people think about this PR: I am fine with it. Other opinions? Julien. |
Is there a bug report at gcc for this ? |
Right, that's a good question. I am not aware of a bug report at GCC for this. It would be good to let them know. I would be interested to know whether they consider this a bug or not. Maybe they are of the opinion that this is an expected behavior. I do not know. We (LAPACK) consider this a compiler bug. But happy to hear other opinions. |
Not that I am aware of. I think is the good place to do so is https://gcc.gnu.org/bugzilla/ |
isnt that stuff part of the ieee754 standard, or unrelated ? |
Since the input and output are both finite, I don't think this relates to the Inf and NaN propagation discussed in the IEEE standard. |
Just as a matter of being complete here. This is the test description: https://netlib.org/lapack/explore-html/de/db5/test__zcomplexdiv_8f_a0a9c3582674d2f2881f3fce922f84d40.html#a0a9c3582674d2f2881f3fce922f84d40 We test divisions with:
The tests using GCC return NaN for the division: |
Would you mind opening a bug report at GCC ? |
No. I can do that! |
Great! thanks |
As far IEEE standard, I am not sure that the IEEE standard defines complex division as part of the standard. They define real division behavior, but the complex division is a construct on top of the real arithmetic. I think this more as to do with FORTRAN standard. |
Done! https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107753 |
I was unaware of the GCC issue but came here to deal with the cross issue. The disable-by-default fix has been sitting unmerged for a while now. Can you please either merge that or the cross fix? |
lapack 3.11 introduced intrinsics tests (#623)
these seem to fail on linux/gcc 12.2, is that a problem ?
also when cross-compiling (CMAKE_CROSSCOMPILING) cmake might not be able to run them
cc @weslleyspereira
The text was updated successfully, but these errors were encountered: