Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from MKL team in LAPACKE interfaces #534

Conversation

sergey-v-kuznetsov
Copy link
Contributor

Description

  1. Intel MKL had a customer bug about wrong wrong NaN checkers in LAPACKE interfaces and most of changes in this commit are related to the usage of wrong checkers in symmetric eigensolvers and some triangular solvers.
  2. Several LAPACKE interfaces like the matrix copy *lacpy, *laset checked info after calling LAPACK kernel which doesn't return info
    LAPACK_dlacpy( &uplo, &m, &n, a, &lda, b, &ldb );
    if( info < 0 ) {
    info = info - 1;
    }
    So the checking info in such cases were removed.
  3. There was redundant requirement in LAPACKE_?gesvd_work interfaces. I mean this line
    if( ldvt < n ) {
    info = -12;
    This requirement must hold only if jobvt='a' or jobvt='s'.
  4. Other changes are minor.

@weslleyspereira
Copy link
Collaborator

Nice job @sergey-v-kuznetsov ! I fixed some minor bugs in the PR sergey-v-kuznetsov#1; could you please review it? I used FFLAGS=-fimplicit-none -frecursive -fcheck=all to find those issues.

@sergey-v-kuznetsov
Copy link
Contributor Author

Thanks Wessley for your changes. I reviewed them and agree. Sorry I didn't know that const is causing problems with FFLAGS=-fimplicit-none -frecursive -fcheck=all. Thanks again

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #534 (4e693fe) into master (799ef93) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   82.34%   82.37%   +0.03%     
==========================================
  Files        1876     1894      +18     
  Lines      188160   190681    +2521     
==========================================
+ Hits       154932   157067    +2135     
- Misses      33228    33614     +386     
Impacted Files Coverage Δ
SRC/iparmq.f 0.00% <0.00%> (ø)
SRC/zhetrd_hb2st.F 97.27% <0.00%> (ø)
SRC/claqz2.f 85.38% <0.00%> (ø)
SRC/zlaqz2.f 85.38% <0.00%> (ø)
SRC/slaqz0.f 79.68% <0.00%> (ø)
SRC/zlaqz0.f 68.32% <0.00%> (ø)
SRC/claqz0.f 66.06% <0.00%> (ø)
SRC/slaqz2.f 100.00% <0.00%> (ø)
SRC/dlaqz1.f 100.00% <0.00%> (ø)
SRC/slaqz3.f 89.23% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799ef93...4e693fe. Read the comment docs.

@weslleyspereira weslleyspereira merged commit 30c9450 into Reference-LAPACK:master Apr 15, 2021
@martin-frbg
Copy link
Collaborator

I notice (a bit late, I know) that this patch restores several instances of the version date information that had just been removed a few days earlier, namely the "Generated line

@weslleyspereira
Copy link
Collaborator

My bad. I reviewed it and forgot to suggest the removal. I fix that in #544

christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this pull request May 23, 2021
…KE_fixes_from_MKL

Fixes from MKL team in LAPACKE interfaces thanks to @sergey-v-kuznetsov.
@julielangou julielangou added this to the LAPACK 3.10.0 milestone Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants