-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes from MKL team in LAPACKE interfaces #534
Fixes from MKL team in LAPACKE interfaces #534
Conversation
Nice job @sergey-v-kuznetsov ! I fixed some minor bugs in the PR sergey-v-kuznetsov#1; could you please review it? I used |
Thanks Wessley for your changes. I reviewed them and agree. Sorry I didn't know that const is causing problems with FFLAGS=-fimplicit-none -frecursive -fcheck=all. Thanks again |
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
==========================================
+ Coverage 82.34% 82.37% +0.03%
==========================================
Files 1876 1894 +18
Lines 188160 190681 +2521
==========================================
+ Hits 154932 157067 +2135
- Misses 33228 33614 +386
Continue to review full report at Codecov.
|
I notice (a bit late, I know) that this patch restores several instances of the version date information that had just been removed a few days earlier, namely the "Generated line |
My bad. I reviewed it and forgot to suggest the removal. I fix that in #544 |
…KE_fixes_from_MKL Fixes from MKL team in LAPACKE interfaces thanks to @sergey-v-kuznetsov.
Description
LAPACK_dlacpy( &uplo, &m, &n, a, &lda, b, &ldb );
if( info < 0 ) {
info = info - 1;
}
So the checking info in such cases were removed.
if( ldvt < n ) {
info = -12;
This requirement must hold only if jobvt='a' or jobvt='s'.