Using CBLAS_INDEX and CBLAS_INT integer types in CBLAS #588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the collaborators think it is a good idea to have two indexes in CBLAS, let's say CBLAS_INDEX and CBLAS_INT (See the discussion in #461). In fact, this was the behavior in CBLAS before 4177968. Moreover, two indexes are still being used in MKL (CBLAS_INDEX and MKL_INT) and OpenBLAS (CBLAS_INDEX and blasint).
In this PR:
cblas.h
that uses two integer definitions, CBLAS_INDEX and CBLAS_INT. CBLAS_INDEX will only be used in the return ofcblas_i*amax
. With that, we restore an ABI that is compatible with other BLAS.size_t
.I am sure we have pros and cons regarding (2), and I hope we can discuss them in this thread.
Additional information:
cblas_i*amax
must convert the return value to CBLAS_INDEX.CBLAS_INDEX = size_t
by default.CBLAS_INDEX = size_t
.Checklist